OK, I had reviewed pico-sdk/src/rp2_common/hardware_i2c/include/hardware/i2c.h in the past, but I guess I did not key in on the comments (by the way are the // PICO_CONFIG lines supposed to be for the statement below these lines, or above, or both?):Well, the SDA and SCL could be #define at the top of any given program, but if I want to leave my library intact that uses SDK I2C functions, then I do need a way outside of the header and source files to specify the instance.
Also, I use VSCodium as my text editor, and it supports the clangd server running on my system. clangd cannot understand the SDK i2c.h header lines:Specifically using the symbol i2c_default causes the red squiggly underscore, and the message:for example if I use this statement in a program:I did solve the annoying clangd messages about not understanding __unused in various SDK headers, to shut that warning up I added this to my custom header:Now the only thing clangd doesn't understand is this in the custom printf.h header:I guess because of the greyed out #else and #endif
With VSCodium, the Microsoft helper is not available, and perhaps caused these warnings that otherwise would not appear for most people.
I guess my I2C instance best practices question is resolved, unless anyone has any feedback, thanks.
Code:
typedef struct i2c_inst i2c_inst_t;// PICO_CONFIG: PICO_DEFAULT_I2C, Define the default I2C for a board, min=0, max=1, default=Usually provided via board header, group=hardware_i2c// PICO_CONFIG: PICO_DEFAULT_I2C_SDA_PIN, Define the default I2C SDA pin, min=0, max=29, default=Usually provided via board header, group=hardware_i2c// PICO_CONFIG: PICO_DEFAULT_I2C_SCL_PIN, Define the default I2C SCL pin, min=0, max=29, default=Usually provided via board header, group=hardware_i2c/** The I2C identifiers for use in I2C functions. * * e.g. i2c_init(i2c0, 48000) * * \ingroup hardware_i2c * @{ */extern i2c_inst_t i2c0_inst;extern i2c_inst_t i2c1_inst;So, of course, this would be the preferred method. If I have my own library that calls uses an SDK I2C function, maybe I should simply add comments to that effect - specify these in your board header, like this:Usually provided via board header
Code:
// usually the I2C pins and default instance are specified in a board header// Override default I2C instance and pins#define PICO_DEFAULT_I2C 0#define PICO_DEFAULT_I2C_SDA_PIN 4#define PICO_DEFAULT_I2C_SCL_PIN 5Also, I use VSCodium as my text editor, and it supports the clangd server running on my system. clangd cannot understand the SDK i2c.h header lines:
Code:
#ifdef PICO_DEFAULT_I2C_INSTANCE#define i2c_default PICO_DEFAULT_I2C_INSTANCE#endifCode:
Use of undeclared identifier 'i2cPICO_DEFAULT_I2C'clang(undeclared_var_use)macro i2c_default#define i2c_default PICO_DEFAULT_I2C_INSTANCECode:
i2c_init(i2c_default, 400 * 1000); // 400 kHzCode:
#ifndef __unused#define __unused __attribute__((unused))#endifCode:
#if !PICO_PRINTF_ALWAYS_INCLUDEDbool __printflike(1, 0) weak_raw_printf(const char *fmt, ...);bool weak_raw_vprintf(const char *fmt, va_list args);Code:
Expected parameter declaratorclang(missing_param)Expected ')'clang(expected)printf.h(65, 18): To match this '('Code:
Expected function body after function declaratorclang(expected_fn_body)With VSCodium, the Microsoft helper is not available, and perhaps caused these warnings that otherwise would not appear for most people.
I guess my I2C instance best practices question is resolved, unless anyone has any feedback, thanks.
Statistics: Posted by breaker — Sat Nov 23, 2024 6:47 pm